-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature detection for unmanaged groups #1604
base: master
Are you sure you want to change the base?
Conversation
I removed the
The NIP 11 document should probably be for describing what a particular relay instance offers rather than anything describing the implementation. I was wrong about this. |
I am confused. Can you give some examples of what does it look like to be a relay that supports both unmanaged and managed groups? Is that a community relay (with already some form of whitelisting and internal rules) that happens to have special rules for some "rooms" -- or is it a relay that allows pretty much anyone to make a random managed group, but also somehow allows ad-hoc unmanaged groups to exist? |
Either one I'd say. My thought was for community relays, rooms would be unmanaged by default, but users could create NIP 29 groups if additional metadata or access controls were desired. But since unmanaged groups provide a subset of the functionality of managed groups, and private nip29 group support implies general nip29 support, it seems pointless to allow unmanaged groups on nip29 relays, since you might as well use the richer, supported groups. In that sense, unmanaged groups are totally orthogonal to nip29 and should probably be their own NIP ultimately. |
I don't think it's totally orthogonal, I think the community relay that evolves to have rooms with permissions is a very good use case. But also maybe we can have another NIP for unmanaged groups, this doesn't prevent the two NIPs from being compatible at the edges, and then we can have the features explicitly signaled via NIP entries on But maybe what we should actually do is create a new NIP-11 field called |
I mean in the sense that the migration will probably happen at a point in time, since a relay can upgrade unilaterally, so there's no reason to support both modes at once.
At this point this is my preference, although |
Feature detection for unmanaged groups has to exist on two levels:
supported_nips
field isn't sufficient, since a relay implementation might support NIP 29, but the actual relay may not.create-group
event instead.The default (obviously) has to be that unmanaged groups are allowed, so unmanaged group support is opt-out.