nip19: remove repeated sentence. #1610
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staab
reviewed
Nov 27, 2024
19.md
Outdated
| @@ -65,5 +63,6 @@ These possible standardized `TLV` types are indicated here: | |||
|
|
|||
| ## Notes | |||
|
|
|||
| - Clients should still accept keys in both hex and npub format for now, and convert internally. | |||
| - `npub` keys MUST NOT be used in NIP-01 events or in NIP-05 JSON responses, only the hex format is supported there. | |||
There was a problem hiding this comment.
Suggested change
| - `npub` keys MUST NOT be used in NIP-01 events or in NIP-05 JSON responses, only the hex format is supported there. | |
| - Unless otherwise specified, bech32 encodings MUST NOT be used in event tags, filters, NIP 05 documents, etc. |
There was a problem hiding this comment.
Maybe can I remove it too?
fiatjaf
reviewed
Nov 27, 2024
Co-authored-by: fiatjaf_ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the sentence similar to the one at the beginning of the document.