Consistent 'method' naming for NIP 47(NWC) Response #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add consistency to the event structure in (NWC). Currently, requests and responses have different keys to identify their method type, which may cause confusion or misunderstandings. This change aims to standardize the key names across all request and response events, making it easier for developers to understand and implement the protocol
|
This change is backwards incompatible, and doesn't introduce any substantial changes, which means it's pretty much DOA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add consistency to the event structure in (NWC).
Currently, requests and responses have different keys to identify their method type, which may cause confusion or misunderstandings.
This change aims to standardize the key names across all request and response events, making it easier for developers to understand and implement the protocol