Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIP-60: add Wallet Backup Events #1834

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanConwayDev
Copy link
Contributor

to prevent loss of funds if Wallet Event is overwritten with a new privkey

@DanConwayDev DanConwayDev changed the title NIP-66: add Wallet Backup Events NIP-60: add Wallet Backup Events Mar 8, 2025
to prevent loss of funds if Wallet Event is overwritten with a new `privkey`
@DanConwayDev DanConwayDev force-pushed the pr/nip-60-add-wallet-backup branch from c5e5a55 to ea1e645 Compare March 8, 2025 18:31
Copy link
Member

@pablof7z pablof7z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I think this is a very sane addition

@trbouma
Copy link

trbouma commented Mar 15, 2025

Why kind 375? My preference would be 7377 (which I am implementing). I think it would be a good idea to keep all the cashu wallet regular events in a 73XX block. I think event kinds <1000 should be reserved for very nostr-generic things versus more specific things, like wallets.

Also, are these backup events for kind 7375 only (i.e., proofs) or other events? If just for 7375, the example should show a proof instead.

@DanConwayDev
Copy link
Contributor Author

Why kind 375? My preference would be 7377 (which I am implementing). I think it would be a good idea to keep all the cashu wallet regular events in a 73XX block. I think event kinds <1000 should be reserved for very nostr-generic things versus more specific things, like wallets.

Kind 375 was chosen to maintain a consistent numbering theme but I'm not precious about it. It is currently implemented in the Applesauce library, being used in experimental wallets within GitWorkshop and Nostrudel. Since 375 is only utilized for experimental wallets, I don't see any issue with transitioning to 7377.

I'll update the PR if @hzrd149 is happy and updates the applesauce.

Also, are these backup events for kind 7375 only (i.e., proofs) or other events? If just for 7375, the example should show a proof instead.

Its a backup the wallet event 17375 only and not each proof. I dont think backing up each proof at a protocol level is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants