support explicit ref or commit (not just HEAD) #29
Conversation
|
I'm curious about the use case for running |
not-an-aardvark
dismissed
their stale review
Accidentally left this comment on the wrong PR (meant to add it to #28)
Basically for funsies I'd like to use lucky-commit in an integration tool, something like bors or github's merge queues. It does have local repositories but they're bare repos and it does all the work on raw oids, using git's plumbing. Technically the repository does have a HEAD but that's just the upstream's default branch, it does not touch the HEAD because it doesn't have a working copy so that's not very useful for its job and moving the HEAD creates potential concurrency issues. Easier to work entirely with oids. Safely working with HEAD would require either having its own big lock around git operations, or using worktrees which is a lot of additional (and not really necessary) complexity.
That is also an option, the integration tool is not in Rust but I could build a bespoke binary. However since I was already futzing in the source for #28 I figured I might as well see if you were interested in slightly extending the interface. |
Implicitly working with `HEAD` can be a chore when trying to use LC on a bare repo or "headless" (scripted). Add support for an optional 2nd parameter, which defaults to `HEAD` but can be any ref or commit oid. If an oid, `update-ref` is skipped. The skip heuristic is to `show-ref` the input, it'll fail on oids but should succeed on every resolveable ref (which we know `ref_` is because we passed it to `cat-file` and it succeeded).
masklinn
force-pushed
the
non-head-support
branch
from
dc15e89 to
43a5c74
Compare
|
Thanks for explaining. Personally, I think it would be better to keep the CLI relatively simple, and I don't think most users of Of course, you're welcome to use a fork that has the option, or to use the Rust API to generate the new commit data directly. |
Implicitly working with
HEADcan be a chore when trying to use LC on a bare repo or "headless" (scripted).Add support for an optional 2nd parameter, which defaults to
HEADbut can be any ref or commit oid. If an oid,update-refis skipped.The skip heuristic is to
show-refthe input, it'll fail on oids but should succeed on every resolveable ref (which we knowref_is because we passed it tocat-fileand it succeeded).