Support Enum numbered variant parsing #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows ser/de of enums such as:
```rust
pub enum Fud {
A = 0,
B = 1,
C = 2,
}
```
Should close not-fl3#101
Signed-off-by: Luke D. Jones <[email protected]>
|
I don't know if this is the best way to do this, I'm basically making a hard assumption that and enum variant with |
|
I've been traveling for work this week, so haven't had time to review yet. Will try to get it done by end of the weekend at least. Thanks for putting this up |
|
No worries mate. Turns out I can't use it in the areas I wanted to due to the pervasiveness of serde, but I have a few other projects I'll be converting. |
not-fl3
approved these changes
May 9, 2024
|
@flukejones Would you mind backing out my commit on this so I can clean it up and merge these separately? |
|
Oh crap sorry I thought you'd already merged. Will do this soon |
|
Should be done now |
|
Thanks @flukejones , this is in now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows ser/de of enums such as:
Should close #101