-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove no_std hashbrown dep #104
Conversation
Fun fact: hashbrown now depends on syn and whatnot, which kind of eleminates the whole purpose of nanoserde
never trust a crates.io dependency, they can bring a full rust parser into your dependency tree at literally any moment :D (not a no-std user here, no opinion on what to do about it) |
Gah thats not cool. Hmmm. Maybe we should just drop hashmap impl when doing no_std? |
I guess that wouldn't be additive though :/ |
7f28eb8
to
f6d3303
Compare
f6d3303
to
db0d90f
Compare
@not-fl3 looks like that was optional, got it down to
|
|
Actually, it was not the case for 0.12 (tho 0.12 use getrandom/wasi...)
|
I guess it makes more sense to make a PR to add nanoserde support for their types in |
334b573
to
0a1fd3f
Compare
0a1fd3f
to
f5f2470
Compare
Alright, ripped it all out now and switched to a BTreeMap for the toml parser internal representation of arrays so that it can be used with no_std |
Wow, such a clever solution, a huge fan of this PR! Somehow I totally overlooked that still totally usable with no_std and we still have std::HashMap support for jsons with std! Looks super good to me! |
Hashbrown added several recursive deps, time to rip it out