-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
put macros and traits of each type behind individual feature flags #70
Conversation
d5aec99
to
3eb5cfb
Compare
ccb6004
to
6cecef1
Compare
6cecef1
to
8a8bca3
Compare
results from rust_serialization_benchmark on this branch vs. master:
Nothing super interesting, but some small improvements (probably due to code size reduction). I ran this forwards and backwards a couple of times, and the results were pretty consistent. For some reason the mesh serialization benchmark seems extremely sensitive to code size. |
I still don't really have an opinion on this, the only input I can give - if I understand how cargo works correctly, than at least one library in the dependency tree with So, in theory, having formats opt-in would make sense. However, personally, I would still prefer to have them all by default. Or I am just too used to just putting |
this is still the case in this PR, all of them are on by default, so hopefully would feel pretty much the same. |
8a8bca3
to
3d5be15
Compare
3d5be15
to
8036419
Compare
Made |
8036419
to
0187151
Compare
I personally am in favour of this PR turning everything on by default. It immediately helps some people, and lets this remain a minor version bump for now. Changing the defaults to be opt-in should ideally be done later, when an actual major version bump will happen. |
What is the status on this? I especially would like to see it merged due to embedded system constraints. |
Also agree with @stefnotch. The sane approach is all enabled by default. Folks who wish to disable parts will certainly do so. |
If it actually solve some issue for you - I think we just need to wait for @knickish for a final approvement and get it merged :) Any chance you want to help with the rebase to get it ready for the merge, @flukejones? |
Sure, will try and get this rebased/fixed up and merged this weekend then |
I've done fixup and PR to @knickish (knickish#7) |
140ef2d
to
98dede0
Compare
Closes #12. Leaving this in draft for a while, pending feedback for or against. Will try to keep PR up to date with current master.
Some timing results on my computer:
Binary Only (clean builds, approximate)
All Default Features (clean builds, approximate)
So ~30% speedup on debug builds and ~40% on release at the cost of a minor version bump