Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json ron deser large numbers error #91

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

knickish
Copy link
Collaborator

@knickish knickish commented Dec 16, 2023

closes #89. The min/max values for non-64bit primitives were all set to use the 64 bit equivalent for some reason, this PR sets them to the appropriate ::MIN/MAX values

@knickish knickish marked this pull request as draft December 16, 2023 16:19
@knickish knickish force-pushed the json_ron_deser_large_numbers_error branch 4 times, most recently from e7b041d to 2e72c32 Compare December 16, 2023 16:33
@knickish knickish force-pushed the json_ron_deser_large_numbers_error branch from 2e72c32 to b55e8d3 Compare December 16, 2023 16:35
@knickish knickish requested a review from not-fl3 December 16, 2023 16:38
@knickish knickish marked this pull request as ready for review December 16, 2023 16:38
@knickish knickish merged commit f8c40d2 into not-fl3:master Dec 16, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit integer wrapping on deserialization causes wrong values
2 participants