This repository has been archived by the owner on Apr 24, 2018. It is now read-only.
PR from 2014, rebased #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- py3 doesn't need the bytes encoding - status_code can simply be retrieved from process.poll() - fixing for pep8 style guidelines - ConnectedCommand.std_out and .std_err now mostly work!
|
@kennethreitz Any chance for merging this and releasing it? |
|
@thedrow done, thanks for offering! Would love to hop on skype briefly to discuss if you have time this week or next :) send an email to [email protected] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Ivoz/envoy PR, rebased as you asked 2 years ago.