Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: release v1.3.1 #1186

Merged
merged 1 commit into from
Feb 24, 2025
Merged

bump: release v1.3.1 #1186

merged 1 commit into from
Feb 24, 2025

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Feb 21, 2025 •
edited by FeynmanZhou
Loading

Release

This would mean tagging as bb571dd v1.3.1 to release.

Vote

We need at least 4 approvals from 6 maintainers to release v1.3.1.

What's Changed

Full Changelog: v1.3.0...bb571dd

Actions

Please review the PR and vote by approving.

@Two-Hearts
bump: release v1.3.1
bb571dd 
Signed-off-by: Patrick Zheng <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.65%. Comparing base (1557a44) to head (bb571dd).
Report is 2 commits behind head on release-1.3.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-1.3    #1186   +/-   ##
============================================
  Coverage        70.65%   70.65%           
============================================
  Files               48       48           
  Lines             2944     2944           
============================================
  Hits              2080     2080           
  Misses             671      671           
  Partials           193      193

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JeyJeyGao
JeyJeyGao approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts
Copy link
Contributor Author

LGTM

shizhMSFT
shizhMSFT approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi
Copy link
Contributor

LGTM

vaninrao10
vaninrao10 approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 394fd06 into notaryproject:release-1.3 Feb 24, 2025
7 checks passed
@Two-Hearts Two-Hearts deleted the release-1.3 branch February 24, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@vaninrao10 vaninrao10 vaninrao10 approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Two-Hearts @priteshbandi @shizhMSFT @JeyJeyGao @vaninrao10