Merge pull request #962 from scientist-softserv/make-groups-for-cdl-only

🐛 Call `CreateGroupAndAddMembersJob` only for CDL

app/jobs/iiif_print/create_relationships_job_decorator.rb

@@ -38,7 +38,7 @@ def perform(parent_id:, parent_model:, child_model:, retries: 0, **)
           end
 
           # OVERRIDE begin
-          CreateGroupAndAddMembersJob.set(wait: 2.minutes).perform_later(parent_id)
+          CreateGroupAndAddMembersJob.set(wait: 2.minutes).perform_later(parent_id) if parent_model == 'Cdl'
           # OVERRIDE end
         else
           # if we aren't ready yet, reschedule the job and end this one normally

spec/jobs/iiif_print/create_relationships_job_decorator_spec.rb

@@ -8,11 +8,23 @@
     let(:parent) { FactoryBot.create(:cdl) }
     let(:child) { FactoryBot.create(:generic_work) }
 
-    it 'calls CreateGroupAndAddMembersJob' do
-      expect(CreateGroupAndAddMembersJob).to receive(:set).with(wait: 2.minutes).and_return(CreateGroupAndAddMembersJob)
-
+    after do
       job.perform(parent_id: parent.id, parent_model: parent.class.to_s, child_model: child.class)
     end
+
+    context 'when parent_model is Cdl' do
+      it 'calls CreateGroupAndAddMembersJob' do
+        expect(CreateGroupAndAddMembersJob).to receive(:set).with(wait: 2.minutes).and_return(CreateGroupAndAddMembersJob)
+      end
+    end
+
+    context 'when parent_model is not Cdl' do
+      let(:parent) { FactoryBot.create(:generic_work) }
+
+      it 'does not call CreateGroupAndAddMembersJob' do
+        expect(CreateGroupAndAddMembersJob).not_to receive(:set)
+      end
+    end
   end
 end
 # rubocop:enable RSpec/FilePath