I910 google analytics #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
reviewed
Dec 8, 2023
jeremyf
reviewed
Dec 8, 2023
jeremyf
suggested changes
Dec 8, 2023
jeremyf
reviewed
Dec 8, 2023
jeremyf
reviewed
Dec 8, 2023
jeremyf
reviewed
Dec 8, 2023
jeremyf
reviewed
Dec 8, 2023
jeremyf
reviewed
Dec 8, 2023
jeremyf
reviewed
Dec 8, 2023
jeremyf
reviewed
Dec 8, 2023
jeremyf
reviewed
Dec 8, 2023
jeremyf
reviewed
Dec 8, 2023
jeremyf
reviewed
Dec 8, 2023
jeremyf
reviewed
Dec 8, 2023
jeremyf
suggested changes
Dec 11, 2023
kirkkwang
force-pushed
the
i910-google-analytics
branch
3 times, most recently
from
81ffd57 to
eb6fc83
Compare
jeremyf
reviewed
Dec 11, 2023
jeremyf
reviewed
Dec 11, 2023
README.md
Outdated
| @@ -256,12 +255,6 @@ Once you run this script the value is on your local computers clipboard. You wil | |||
| | FCREPO_TEST_BASE_PATH | Fedora root path used for test instance | /test | yes | |||
| | FCREPO_TEST_PORT | Test port for the fedora repo 8986 | yes | | |||
| | GOOGLE_ANALYTICS_ID | The Google Analytics account id. Disabled if not set | - | no | | |||
| | GOOGLE_OAUTH_APP_NAME | The name of the application. | - | no | | |||
There was a problem hiding this comment.
These should also be restored
kirkkwang
force-pushed
the
i910-google-analytics
branch
from
eb6fc83 to
1a36dc8
Compare
jeremyf
approved these changes
Dec 11, 2023
kirkkwang
force-pushed
the
i910-google-analytics
branch
from
1a36dc8 to
f80a487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
🧹 Revert and modify previous Google Analytics work
06aa95b
This commit will revert the previous Google Analytics work and modify it
to use the new Google Analytics 4 (GA4) tracking code.
Ref:
🎁 Overwrite Hyrax's ga4 partial
3231692
This commit will overwrite Hyrax's ga4 partial to handle Hyku's
multitenancy.
Ref:
Expected Behavior Before Changes
Google Analytics was using the deprecated Universal Analytics from Google Analytics.
Expected Behavior After Changes
Now we are using Google Analytics 4.
Screenshots / Video
Proprietor
Tenant same as Proprietor
Tenant Google Analytics ID not set
Tenant different than Proprietor
Google Analytics Dashboard with one visitor (me)