🧹 Tighten tenant GA ID logic #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `#current_account` method returns a tenant instance when on the proprietor page (not in a tenant subdomain). This then looks for a `HYKU_GOOGLE_ANALYTICS_ID` instead of the `GOOGLE_ANALYTICS_ID` env variable. We want to only use the `GOOGLE_ANALYTICS_ID`. Ref: - #910
laritakr
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#current_accountmethod returns a tenant instance when on the proprietor page (not in a tenant subdomain). This then looks for aHYKU_GOOGLE_ANALYTICS_IDinstead of theGOOGLE_ANALYTICS_IDenv variable. We want to only use theGOOGLE_ANALYTICS_ID.Ref: