DON'T MERGE - i852 demo deploy test branch #957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets us up for future improvements to derivative job processing
This doesn't work. This commit is only here to document that this solution was attempted.
There is no way to reassign a job to another queue once it has been created. To use the new :resource_intensive Sidekiq queue, we need a separate job class that is configured to use that queue. Enter CreateLargeDerivativesJob. It functions exactly the same as CreateDerivativesJob, except that it queues into the :resource_intensive queue and has a higher priority. This way, we can have two separate job classes with different Sidekiq configurations while using the same application logic for both.
At present, this is the only job going into this queue, so specifying a higher priority doesn't make sense since all jobs in the queue will have the same priority regardless
This reverts commit e8af165.
This reverts commit 9194865.
Co-authored-by: Rob Kaufman <[email protected]>
…52-demo-deploy-test-branch
bkiahstroud
changed the title
Change pulled from: - samvera/hyku#2145
…52-demo-deploy-test-branch
Because of the special way `extraDeploy` gets interpreted, fetching ENV values using `$` will not work.
…52-demo-deploy-test-branch
The correct value should be `$REDIS_HOST:6379`. In Helm templates, using `$$` will skip variable substitution and use the correct value.
The correct value should be `$REDIS_HOST:6379`. In Helm templates, using `$$` will skip variable substitution and use the correct value.
…52-demo-deploy-test-branch
The previous commit/attempt produced: `sh -c 'db-wait.sh "$:6379"'` So some variable substitution is still happening. Wrapping the command in single quotes may prevent that.
The previous commit/attempt produced: `sh -c 'db-wait.sh "$:6379"'` So some variable substitution is still happening. Wrapping the command in single quotes may prevent that.
…52-demo-deploy-test-branch
…52-demo-deploy-test-branch
…52-demo-deploy-test-branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this PR.
The only purpose of this PR is to kick off a build so we can deploy. After that, this can be closed.
This PR combines the WIP changes introduced is these #852-related PRs:
These changes will be merged into
mainin their own respective PRs.