-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deno] update to latest commit #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chili-Man
previously approved these changes
Sep 15, 2023
rgbkrk
previously approved these changes
Sep 15, 2023
rgbkrk
previously approved these changes
Sep 15, 2023
rgbkrk
reviewed
Sep 16, 2023
rgbkrk
reviewed
Sep 16, 2023
rgbkrk
previously approved these changes
Sep 16, 2023
rgbkrk
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
https://github.com/bartlomieju/deno/commits/jupyter2/
Looks like it's checking for kernelspecs now, need to fix before we mergehttps://github.com/noteable-io/kernels/assets/7707189/816c1f1e-b861-44ad-b156-597ec476cc0b
edit: looks like there were a couple CLI changes under the hood that required a few extra pieces:
a)
jupyter
command to get the list of available kernelspecs (https://github.com/bartlomieju/deno/blob/jupyter2/cli/tools/jupyter/install.rs#L12-L15)b)
--kernel
flag added todeno jupyter
to explicitly start the kernelIssue ticket number and link
Checklist before requesting a review