Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deno] update to latest commit #43

Merged
merged 9 commits into from
Sep 16, 2023
Merged

[deno] update to latest commit #43

merged 9 commits into from
Sep 16, 2023

Conversation

shouples
Copy link
Contributor

@shouples shouples commented Sep 15, 2023

Describe your changes

https://github.com/bartlomieju/deno/commits/jupyter2/

Looks like it's checking for kernelspecs now, need to fix before we merge
https://github.com/noteable-io/kernels/assets/7707189/816c1f1e-b861-44ad-b156-597ec476cc0b

edit: looks like there were a couple CLI changes under the hood that required a few extra pieces:
a) jupyter command to get the list of available kernelspecs (https://github.com/bartlomieju/deno/blob/jupyter2/cli/tools/jupyter/install.rs#L12-L15)
b) --kernel flag added to deno jupyter to explicitly start the kernel

$ deno jupyter --help
Deno kernel for Jupyter notebooks

Usage: deno jupyter [OPTIONS]

Options:
      --install      Installs kernelspec, requires 'jupyter' command to be available.
      --unstable     Enable unstable features and APIs
      --kernel       Start the kernel
      --conn <conn>  Path to JSON file describing connection parameters, provided by Jupyter
  -q, --quiet        Suppress diagnostic output
  -h, --help         Print help

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I am able to build images locally
  • Has the issue it resolves been discussed with maintainers?

@shouples shouples requested review from a team as code owners September 15, 2023 21:17
@shouples shouples changed the title update to latest commit [deno] update to latest commit Sep 15, 2023
Chili-Man
Chili-Man previously approved these changes Sep 15, 2023
rgbkrk
rgbkrk previously approved these changes Sep 15, 2023
@shouples shouples marked this pull request as draft September 15, 2023 22:49
@shouples shouples dismissed stale reviews from rgbkrk and Chili-Man via 052d05c September 15, 2023 23:07
@shouples shouples marked this pull request as ready for review September 15, 2023 23:11
rgbkrk
rgbkrk previously approved these changes Sep 15, 2023
deno/run.sh Outdated Show resolved Hide resolved
rgbkrk
rgbkrk previously approved these changes Sep 16, 2023
@shouples shouples removed the request for review from Chili-Man September 16, 2023 17:20
@shouples shouples merged commit 27a34b7 into main Sep 16, 2023
9 checks passed
@shouples shouples deleted the djs/new-deno-build branch September 16, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants