Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove symlink #62

Merged
merged 2 commits into from
Oct 26, 2023
Merged

remove symlink #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56e52a2
changelog
shouples Oct 26, 2023
4035cab
remove symlinks
shouples Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased

### Removed
- Symlink between `/etc/noteable` (old) and `/var/run/noteable` (new)

## [0.0.2] - 2023-09-20
### Fixed
- Fixed variable generation on release pipelines
Expand Down
4 changes: 0 additions & 4 deletions deno/base/1.37/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ RUN groupadd --gid 4004 noteable && \
chown --recursive noteable:noteable "${NBL_HOME_DIR}" && \
mkdir -p "${NBL_WORK_DIR}" && chown --recursive noteable:noteable "${NBL_WORK_DIR}"

# TEMPORARY: symlink the previous /etc/noteable to the new NBL_WORK_DIR (/var/run/noteable) dir
# until all other services are migrated and the old /etc/noteable can be removed
RUN ln -s "${NBL_WORK_DIR}" /etc/noteable

WORKDIR /tmp

COPY apt-install /usr/bin/
Expand Down
4 changes: 0 additions & 4 deletions python/base/3.10/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ RUN groupadd --gid 4004 noteable && \
mkdir /opt/venv && chown noteable:noteable /opt/venv && \
mkdir /etc/ipython && chown noteable:noteable /etc/ipython

# TEMPORARY: symlink the previous /etc/noteable to the new NBL_HOME_DIR (/var/run/noteable) dir
# until all other services are migrated and the old /etc/noteable can be removed
RUN ln -s "${NBL_WORK_DIR}" /etc/noteable

WORKDIR /tmp

# Install tini to manage passing signals to the child kernel process
Expand Down
4 changes: 0 additions & 4 deletions python/base/3.11/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ RUN groupadd --gid 4004 noteable && \
mkdir /opt/venv && chown noteable:noteable /opt/venv && \
mkdir /etc/ipython && chown noteable:noteable /etc/ipython

# TEMPORARY: symlink the previous /etc/noteable to the new NBL_WORK_DIR (/var/run/noteable) dir
# until all other services are migrated and the old /etc/noteable can be removed
RUN ln -s "${NBL_WORK_DIR}" /etc/noteable

WORKDIR /tmp

# Install tini to manage passing signals to the child kernel process
Expand Down
4 changes: 0 additions & 4 deletions python/base/3.9/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ RUN groupadd --gid 4004 noteable && \
mkdir /opt/venv && chown noteable:noteable /opt/venv && \
mkdir /etc/ipython && chown noteable:noteable /etc/ipython

# TEMPORARY: symlink the previous /etc/noteable to the new NBL_WORK_DIR (/var/run/noteable) dir
# until all other services are migrated and the old /etc/noteable can be removed
RUN ln -s "${NBL_WORK_DIR}" /etc/noteable

WORKDIR /tmp

# Install tini to manage passing signals to the child kernel process
Expand Down
4 changes: 0 additions & 4 deletions r/base/4.3.0/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ RUN groupadd --gid 4004 noteable && \
mkdir -p "${NBL_WORK_DIR}" && chown --recursive noteable:noteable "${NBL_WORK_DIR}" && \
chown --recursive noteable:noteable /usr/local/lib/R/site-library

# TEMPORARY: symlink the previous /etc/noteable to the new NBL_WORK_DIR (/var/run/noteable) dir
# until all other services are migrated and the old /etc/noteable can be removed
RUN ln -s "${NBL_WORK_DIR}" /etc/noteable

# Install tini to manage passing signals to the child kernel process
ENV TINI_VERSION v0.19.0
ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini
Expand Down
4 changes: 0 additions & 4 deletions rust/base/1.70/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ RUN groupadd --gid 4004 noteable && \
chown --recursive noteable:noteable "${NBL_HOME_DIR}" && \
mkdir -p "${NBL_WORK_DIR}" && chown --recursive noteable:noteable "${NBL_WORK_DIR}"

# TEMPORARY: symlink the previous /etc/noteable to the new NBL_WORK_DIR (/var/run/noteable) dir
# until all other services are migrated and the old /etc/noteable can be removed
RUN ln -s "${NBL_WORK_DIR}" /etc/noteable

WORKDIR /tmp

COPY apt-install /usr/bin/
Expand Down