Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singlestore conn attrs #130

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Singlestore conn attrs #130

merged 4 commits into from
Aug 3, 2023

Conversation

rohitsanj
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Unit tests are present
  • Have you validated this change locally?

Summary of Changes

  • Create a new SingleStoreDBConnection class with preprocessing logic to add SingleStore connection attributes program_name and program_version corresponding to noteable and this package's version respectively.
  • Replace sqlalchemy-singlestoredb installation with explicit singlestoredb installation and sqlalchemy as extras.

Excerpt from an email from one of the SingleStore representatives:

We are requesting all SingleStore partners add a connection attribute to their connector to SingleStore, which will enable us to identify details about connections made to customers' SingleStore instances. It will help us track the health of the integration and joint customers. We will also be able to share these details across with Noteable.

@rohitsanj rohitsanj requested a review from jlrobins July 27, 2023 21:56
@rohitsanj
Copy link
Contributor Author

rohitsanj commented Jul 27, 2023

We need to bump cryptography to a minimum of 41.0.0 in order to avoid security vulnerabilities - https://pyup.io/v/59062/f17/.

However, snowflake-connector-python upper bound restricts it from being updated to that version. There's an open issue here tracking a new release with an upgraded cryptography version and one of the maintainers mentioned it should be out by Monday, if not earlier.

I guess.. we're blocked until then? @jlrobins @tizz98

 name         : cryptography
 version      : 40.0.2
 description  : cryptography is a package which provides cryptographic recipes and primitives to Python developers.

dependencies
 - cffi >=1.12

required by
 - pyopenssl >=38.0.0,<40.0.0 || >40.0.0,<40.0.1 || >40.0.1,<42
 - snowflake-connector-python >=3.1.0,<41.0.0

@tizz98
Copy link
Contributor

tizz98 commented Jul 28, 2023

@rohitsanj yeah pretty blocked it seems, let's see again on monday

@rohitsanj
Copy link
Contributor Author

Updated snowflake-connector-python to 3.1.0 and cryptography to 41.x

@rohitsanj rohitsanj merged commit 4399550 into main Aug 3, 2023
2 checks passed
@rohitsanj rohitsanj deleted the singlestore-conn-attrs branch August 3, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants