add comment

notifo-io · Jan 26, 2023 · dee5c88 · dee5c88
1 parent 6ba226f
commit dee5c88
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -8,7 +8,7 @@
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageProjectUrl>https://notifo.io</PackageProjectUrl>
     <PackageTags>notifo xamarin firebase</PackageTags>
-    <Version>1.2.1-beta1</Version>
+    <Version>1.2.1-beta2</Version>
     <LangVersion>9</LangVersion>
   </PropertyGroup>
 </Project>
diff --git a/sdk/Notifo.SDK.Core/NotifoMobilePush/NotifoMobilePushImplementation.ios.cs b/sdk/Notifo.SDK.Core/NotifoMobilePush/NotifoMobilePushImplementation.ios.cs
@@ -155,6 +155,8 @@ private async Task<List<UserNotificationDto>> GetPendingNotifications1_0Async(in
         private async Task<List<UserNotificationDto>> GetPendingNotifications1_4Async(int take, DateTime after,
             CancellationToken ct)
         {
+            // use DeviceIdentifier because Token could change over time and you could miss pending notifications. DeviceIdentifier should be more stable.
+            // take is not returning the exact amount of entries. It's taking the X last entries, then filters for messages that are unseen.
             var result = await Client.Notifications.GetMyDeviceNotificationsAsync(DeviceIdentifier, after, true, take * 2, ct);
 
             return result.Items;