Fix/completed collection error #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… additions". by removing "queue.CompleteAdding();" from completeAsync for logout. This issue happened if user logged out and directly logged back in again without closing app first
|
This cannot work. Because we dispose everything then. The question is, if we even have to call the CompleteAsync() here. |
|
@SebastianStehle i think we do need it. Because otherwise the token is not deleted |
|
Then you have to either create a new queue after that or you have to reimplement the completion mechanism with something more sophisticated. We can discuss this over a call. |
|
you know how to reach me :-). Feel free to contact me as soon as you have time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… additions". by removing "queue.CompleteAdding();" from completeAsync for logout.
This issue happened if user logged out and directly logged back in again without closing the app first. If we mark the collection as "completed" we cannot add the command to register.
I tested it locally with our app. Login -> Logout -> login worked without any issues. Token got updated