Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 'archived' property and added 'in_trash' property. #417

Conversation

kosaku-hayashi
Copy link
Contributor

@kosaku-hayashi kosaku-hayashi commented Jul 13, 2024

Description

The Archived properties defined for Block, Page, and Database objects have been deprecated and replaced with new InTrash properties. The API reference has not yet been edited to the new InTrash in some places (block update page), but all API responses seem to have been adapted to InTrash.Migration from Archived to InTrash properties has no functional differences other than the name change, so simply replacing them will cause all existing APIs to work properly.
I have also modified the test code for the areas applicable to the change.

Fixes #410

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Unit testing was successfully completed and the various APIs (query, update, search) affected by the change were tested in Notion.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Comment

If you need to maintain backward compatibility and support both Archived and InTrash properties, please contact us again!

@kosaku-hayashi kosaku-hayashi force-pushed the issue-410-Archived-property-is-getting-deprecated branch from d6b800a to 08ed291 Compare July 14, 2024 05:58
@kosaku-hayashi
Copy link
Contributor Author

Sorry. I forgot to add the renamed TrashPageResponse.json and had to push it back.

@KoditkarVedant KoditkarVedant self-requested a review October 29, 2024 11:07
@KoditkarVedant KoditkarVedant merged commit 4a1bcce into notion-dotnet:main Oct 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Archived" property is getting deprecated
2 participants