Skip to content

Commit

Permalink
Revert "Try app release channels"
Browse files Browse the repository at this point in the history
This reverts commit d2958a4.
  • Loading branch information
jamezrin committed Dec 25, 2021
1 parent d2958a4 commit 8ae7880
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 21 deletions.
14 changes: 4 additions & 10 deletions .github/workflows/notion-repackaged.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
echo "::set-output name=notion_download_hash::$NOTION_DOWNLOAD_HASH"
echo "::set-output name=notion_enhancer_desktop_commit::$NOTION_ENHANCER_DESKTOP_COMMIT"
NOTION_REPACKAGED_VERSION_REV="${NOTION_VERSION}-{0}.${NOTION_REPACKAGED_REVISION}"
NOTION_REPACKAGED_VERSION_REV="${NOTION_VERSION}-${NOTION_REPACKAGED_REVISION}"
echo "::set-output name=notion_repackaged_version_rev::$NOTION_REPACKAGED_VERSION_REV"
outputs:
notion_version: ${{ steps.preload-variables.outputs.notion_version }}
Expand All @@ -42,17 +42,14 @@ jobs:
name: Create release
runs-on: ubuntu-latest
needs: [preload-variables]
strategy:
matrix:
edition: [vanilla, enhanced]
steps:
- uses: actions/checkout@v2
- uses: release-drafter/release-drafter@v5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
version: ${{ format(needs.preload-variables.outputs.notion_repackaged_version_rev, matrix.edition) }}
tag: v${{ format(needs.preload-variables.outputs.notion_repackaged_version_rev, matrix.edition) }}
version: ${{ needs.preload-variables.outputs.notion_repackaged_version_rev }}
tag: v${{ needs.preload-variables.outputs.notion_repackaged_version_rev }}

make-vanilla-sources:
name: Make vanilla sources
Expand Down Expand Up @@ -82,11 +79,8 @@ jobs:

make-enhanced-sources:
name: Make enhanced sources
runs-on: ubuntu-latest
needs: [make-vanilla-sources, preload-variables]
env:
NOTION_VERSION: ${{ needs.preload-variables.outputs.notion_version }}
NOTION_REPACKAGED_REVISION: ${{ needs.preload-variables.outputs.notion_repackaged_revision }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Install icnsutils and moreutils
Expand Down
10 changes: 2 additions & 8 deletions scripts/enhance-src.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ source `dirname $0`/_utils.sh
workdir ${WORKSPACE_BUILD_DIR}

check-cmd jq git convert png2icns node sponge
check-env NOTION_VERSION NOTION_REPACKAGED_REVISION NOTION_ENHANCER_DESKTOP_COMMIT
check-env NOTION_ENHANCER_DESKTOP_COMMIT

if [ -d "${NOTION_ENHANCED_SRC_NAME}" ]; then
log "Removing already enhanced sources..."
Expand All @@ -23,13 +23,7 @@ pushd "${NOTION_ENHANCED_SRC_NAME}" > /dev/null

log "Patching package.json for being enhanced..."

NOTION_APP_PACKAGE_VERSION="${NOTION_VERSION}-enhanced.${NOTION_REPACKAGED_REVISION}"

jq \
--arg version "${NOTION_APP_PACKAGE_VERSION}" \
'.name="notion-app-enhanced" |
.version=$version' \
package.json | sponge package.json
jq '.name="notion-app-enhanced"' package.json | sponge package.json

popd > /dev/null

Expand Down
6 changes: 3 additions & 3 deletions scripts/extract-src.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ log "Copying original app resources..."
mkdir -p "${NOTION_VANILLA_SRC_NAME}"
cp -r "${NOTION_EXTRACTED_APP_NAME}/resources/app/"* "${NOTION_VANILLA_SRC_NAME}"

export NOTION_REPACKAGED_VERSION_REV="${NOTION_VERSION}-${NOTION_REPACKAGED_REVISION}"

pushd "${NOTION_VANILLA_SRC_NAME}" > /dev/null

log "Patching and cleaning source"
Expand All @@ -58,13 +60,11 @@ find . -type f -name "*.js.map" -exec rm {} +

log "Adapting package.json including fixes..."

NOTION_APP_PACKAGE_VERSION="${NOTION_VERSION}-vanilla.${NOTION_REPACKAGED_REVISION}"

jq \
--arg version "${NOTION_APP_PACKAGE_VERSION}" \
--arg homepage "${NOTION_REPACKAGED_HOMEPAGE}" \
--arg repo "${NOTION_REPACKAGED_REPO}" \
--arg author "${NOTION_REPACKAGED_AUTHOR}" \
--arg version "${NOTION_REPACKAGED_VERSION_REV}" \
'.dependencies.cld="2.7.0" |
.name="notion-app" |
.homepage=$homepage |
Expand Down

0 comments on commit 8ae7880

Please sign in to comment.