Upgraded to org.apache.httpcomponents:httpclient:4.3.5 to fix CVE-2014-3... #208

vibe13 · 2014-12-10T12:46:08Z

...577 vulnerability of commons-httpclient:commons-httpclient:3.1

…4-3577 vulnerability of commons-httpclient:commons-httpclient:3.1

vibe13 · 2014-12-10T12:46:25Z

@matzew mind to review? Thanks!

matzew · 2014-12-11T09:57:29Z

👀 at it

matzew · 2014-12-11T11:26:44Z

src/main/java/com/notnoop/apns/internal/TlsTunnelBuilder.java

-            }
-
+
+            HttpParams httpParams = new BasicHttpParams();


The HttpParams class has been deprecated

matzew · 2014-12-11T11:27:03Z

when using an IP address, I am getting this:

Caused by: java.net.ProtocolException: Error occurred while creating proxy socket : java.lang.IllegalArgumentException: Host name may not be blank
    at com.notnoop.apns.internal.TlsTunnelBuilder.makeTunnel(TlsTunnelBuilder.java:111)
    at com.notnoop.apns.internal.TlsTunnelBuilder.build(TlsTunnelBuilder.java:70)
    at com.notnoop.apns.internal.ApnsConnectionImpl.getOrCreateSocket(ApnsConnectionImpl.java:272)

Upgraded to org.apache.httpcomponents:httpclient:4.3.5 to fix CVE-201…

ae10e82

…4-3577 vulnerability of commons-httpclient:commons-httpclient:3.1

matzew reviewed Dec 11, 2014
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgraded to org.apache.httpcomponents:httpclient:4.3.5 to fix CVE-2014-3... #208

Upgraded to org.apache.httpcomponents:httpclient:4.3.5 to fix CVE-2014-3... #208

vibe13 commented Dec 10, 2014

vibe13 commented Dec 10, 2014

matzew commented Dec 11, 2014

matzew Dec 11, 2014

matzew commented Dec 11, 2014

Upgraded to org.apache.httpcomponents:httpclient:4.3.5 to fix CVE-2014-3... #208

Are you sure you want to change the base?

Upgraded to org.apache.httpcomponents:httpclient:4.3.5 to fix CVE-2014-3... #208

Conversation

vibe13 commented Dec 10, 2014

vibe13 commented Dec 10, 2014

matzew commented Dec 11, 2014

matzew Dec 11, 2014

Choose a reason for hiding this comment

matzew commented Dec 11, 2014