Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added method to set 'mutable-content' to 1. Fixes #321, #328. #331

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added method to set 'mutable-content' to 1. Fixes #321, #328. #331

wants to merge 2 commits into from

Conversation

cemcatik
Copy link

No description provided.

@cemcatik
Copy link
Author

Any idea how to resolve the timeout error? It's not related to this changelist and I can't repro locally.

Results :

Tests in error: 
  sendOneSimple(com.notnoop.apns.integration.ApnsConnectionTest): test timed out after 2000 milliseconds

Tests run: 112, Failures: 0, Errors: 1, Skipped: 3

grippy
grippy reviewed Apr 11, 2017
View reviewed changes
src/main/java/com/notnoop/apns/PayloadBuilder.java
return this;
}

/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this comment below is helpful, I would delete it since it doesn't have anything to setting mutable-content.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's just auto-formatted the javadoc of the .method below. I'll clean it up in a bit. Thanks

@grippy
Copy link

grippy commented Apr 11, 2017

@cemcatik - One minor issue.

@matzew It looks like you merged the last PR on this repo. Are you still maintaining it? Any idea what we need to do to get this error resolved so we can merge this and publish a new release?

grippy
grippy approved these changes Apr 11, 2017
View reviewed changes
Copy link

@grippy grippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Hoping this gets merged & released in the near future 😄

@raderio raderio mentioned this pull request Jul 25, 2017
Open
@satishbotla
Copy link

any one merging this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grippy grippy grippy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cemcatik @grippy @satishbotla