Skip to content

Commit

Permalink
Update build process
Browse files Browse the repository at this point in the history
  • Loading branch information
@simoncozens
simoncozens committed Nov 8, 2024
1 parent 2901d18 commit c5c3e73
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ venv: venv/touchfile

build.stamp: venv .init.stamp sources/config*.yaml $(SOURCES)
rm -rf fonts
(for config in sources/config*.yaml; do . venv/bin/activate; python3 -m notobuilder $$config; done) && touch build.stamp
(for config in sources/config*.yaml; do . venv/bin/activate; gftools-builder $$config; done) && touch build.stamp

.init.stamp: venv
. venv/bin/activate; python3 scripts/first-run.py
Expand Down
1 change: 1 addition & 0 deletions sources/config-sans-myanmar-ui.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ googleFonts: true
includeSubsets:
- from: Noto Sans
name: GF_Latin_Core
recipeProvider: noto
sources:
- NotoSansMyanmarUI.glyphs
1 change: 1 addition & 0 deletions sources/config-sans-myanmar.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ googleFonts: true
includeSubsets:
- from: Noto Sans
name: GF_Latin_Core
recipeProvider: noto
sources:
- NotoSansMyanmar.glyphs
1 change: 1 addition & 0 deletions sources/config-serif-myanmar.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ googleFonts: true
includeSubsets:
- from: Noto Serif
name: GF_Latin_Core
recipeProvider: noto
sources:
- NotoSerifMyanmar.glyphs

2 comments on commit c5c3e73

@YusukeShirakihara
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simoncozens
First of all, I would like to express my gratitude for the wonderful updates you have made.
I truly appreciate the effort and dedication put into this project.

I have noticed a minor detail that I would like to bring to your attention.
The full version of the font includes Latin glyphs, but when looking at the Fonts (HEAD build), it seems that the Latin glyphs for Regular, Medium, Semi Bold, and Bold weights are all using the Regular weight.
This issue appears to be present only in Noto Sans Myanmar and Noto Sans Myanmar UI.
I apologize if this comes across as nitpicking, but I believe it is important to ensure the highest quality for this amazing project.

Could you please take a look at this issue at your convenience?
Thank you very much for your time and consideration.

@simoncozens
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report - I removed the semibold masters from Noto Sans Myanmar and Noto Sans Myanmar UI and now full builds are working across the weight range.

Please sign in to comment.