Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash on invalid lock in litmus test #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gstrauss
Copy link

@gstrauss gstrauss commented Feb 5, 2023

fix crash on invalid lock in litmus test

This commit is from 2016 for an issue I ran into with litmus when I was bringing lighttpd mod_webdav up to RFC4918. I do not have immediate example of the item it fixes, but the change is only a couple lines and the commit message describes the issues it fixes.

If there are questions, please ask and I'll add more details.

Similar in age to notroj/litmus#6

@notroj
Copy link
Owner

notroj commented Feb 6, 2023

Do you know how it happened that a lock ended up in the store without a valid URI? I'm not necessarily against the patch but I'm wondering if it is something that should have been caught and treated as an error earlier, rather than crashing here.

@gstrauss
Copy link
Author

gstrauss commented Feb 7, 2023

Do you know how it happened that a lock ended up in the store without a valid URI?

Back in 2016, I was using litmus (thank you!) to improve a then-non-compliant (with RFC4918) WebDAV implementation. I suppose I could copy out an old version from 2015 and see if I can reproduce this. I'll need to find some time to do so, but intend to update this when I do, hopefully later this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants