Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impose maximum on port string in URI parser #182

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Impose maximum on port string in URI parser #182

merged 1 commit into from
Dec 2, 2024

Conversation

notroj
Copy link
Owner

@notroj notroj commented Nov 30, 2024 

* src/ne_uri.c (ne_uri_parse): Restrict the maximum allowed port to
  65535, parse the port number directly rather than via atoi().

* test/uri-tests.c (failparse): Test that an excessively long port number fails to parse.

@notroj notroj force-pushed the uri-parse-max-port branch from 158a5fc to 7b835c5 Compare November 30, 2024 15:44
@notroj
* src/ne_uri.c (ne_uri_parse): Restrict the maximum allowed port to
a75bc32 
  65535, parse the port number directly rather than via atoi().

* test/uri-tests.c (failparse): Test that an excessively long port
  number fails to parse.
@notroj notroj force-pushed the uri-parse-max-port branch from 7b835c5 to a75bc32 Compare December 2, 2024 17:17
@notroj notroj merged commit 9a23c93 into master Dec 2, 2024
146 checks passed
@notroj notroj deleted the uri-parse-max-port branch December 2, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@notroj