Skip to content

Commit

Permalink
Re-do fix for #537 without regression
Browse files Browse the repository at this point in the history
Ignore versions for "None" models, such as where the model has subsequently been deleted (eventchecklistcrew and eventchecklistvehicle). Now it makes sense...
  • Loading branch information
FreneticScribbler committed Jun 28, 2023
1 parent 677f352 commit 1ce6ec3
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions versioning/versioning.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,15 +160,15 @@ def item_changes(self):

# Build some dicts of what we have
item_dict = {} # build a list of items, key is the item_pk
if len(new_item_versions) == 0:
return None
for version in old_item_versions: # put all the old versions in a list
if version is None or version.object is None:
continue
compare = ModelComparison(old=version._object_version.object, **comparisonParams)
item_dict[version.object_id] = compare
if version._model is None:
continue
compare = ModelComparison(old=version._object_version.object, **comparisonParams)
item_dict[version.object_id] = compare

for version in new_item_versions: # go through the new versions
if version._model is None:
continue
try:
compare = item_dict[version.object_id] # see if there's a matching old version
compare.new = version._object_version.object # then add the new version to the dictionary
Expand Down

0 comments on commit 1ce6ec3

Please sign in to comment.