Reimplement rigboard page in a fully responsive manner #567
Conversation
(cherry picked from commit b3939d8) # Conflicts: # pipeline/source_assets/scss/dark_screen.scss
FreneticScribbler
changed the title
FreneticScribbler
temporarily deployed
to
pyrigs-pipel-subgrid-wzvslhqeo
|
I think this is now good to go if you're happy for me to merge it @nickw29 ? It's not perfect, and I bet someone's got a device that sits in a weird screen size spot, but it's better than the current sidescroll table by a mile! |
|
And so continues (barely) the long standing tradition of RIGS development during NAT panto 😆 |
|
|
|
Works on my device! Maybe I'm the one with a weird screen size, lol.
How wide is your screen?
Sent from Proton Mail mobile
…-------- Original Message --------
On 17 Dec 2023, 18:56, nickw29 wrote:
[Screenshot_20231217-184605.png (view on web)](https://github.com/nottinghamtec/PyRIGS/assets/125134354/0148ce5e-47fe-4e5d-82ee-2dc6e120bd21)
Small issue on Chrome on android
—
Reply to this email directly, [view it on GitHub](#567 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAZNN7IDWVCETLW3YNQOZ2LYJ456RAVCNFSM6AAAAAA6LDHW6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGI2TCMBUGI).
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
I've gone back to a phone with a normal sized screen, 20:9 - 2400x1080 - 6.4" Edit: Phone is a Pixel 6 |
|
FYI this is what it looks like on my iPhone 14 Pro Max (1284px × 2778px, 430px × 932px viewport, CSS Pixel Ratio of 3)
|
|
Looks good to me on your iPhone Jerbs, until you turn it landscape and then all manner of layout horrors fall out 😱 No idea why the header isn't full width. The rigboard should end where the new button is, as well, it's somehow leaking out of the page layout. Gak. Nick, I was gonna guess that you were the one person in the data I pulled that had a weirdly ultra old version of Chrome, but I'm not sure that's allowed in Google Pixel land? If I set my viewport to the size it theoretically is on your phone, it doesn't break, so I'm a little stumped honestly! |
|
Yeah, my phone and browser are up to date. |
|
|
|
Oh dear...
Sent from Proton Mail mobile
…-------- Original Message --------
On 21 Jan 2024, 19:21, nickw29 wrote:
[image.png (view on web)](https://github.com/nottinghamtec/PyRIGS/assets/125134354/e45470fb-104a-42a2-a7aa-fca9ff0788e6)
This is an interesting look
—
Reply to this email directly, [view it on GitHub](#567 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAZNN7MRMGCG3ZRU7R4A6OLYPVTB5AVCNFSM6AAAAAA6LDHW6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSG4ZTIMBYGU).
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
Should be fixed momentarily. Still can't reproduce any of the other problems on either Firefox or Brave (chromium based) 🤔 |
(cherry picked from commit b3939d8)
Requires refinement. Opening in order to get a review app going.