Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finance dashboard #600

Merged

Conversation

jb3
Copy link
Member

@jb3 jb3 commented Oct 19, 2024

Adds a new finance dashboard requested by Alfie which should allow for some interesting figures to be presented in the upcoming General Meeting.

image

This follows the same RBAC as other routes within the invoices section of the application so only trusted users can view this information.

Time periods allow for figures to be viewed for all time, for the last week, month or year.

The above screenshot misattributes payment sources as they are not part of the seeded data generated by the bootstrap script, though this data is accurately attributed in production.

@FreneticScribbler
Copy link
Member

Oh that's *$%ing sexy. Damn.

The layout does feel a bit 'tablet' to me, but that's a personal preference for sure.

I'll give it the in depth look it deserves shortly, but ⭐. Nice.

@FreneticScribbler
Copy link
Member

Feels like we need better test data finance wise now! 😆

@jb3 jb3 force-pushed the jb3/features/invoice-dashboard branch from 2aefc01 to 55f4596 Compare October 24, 2024 15:54
@FreneticScribbler FreneticScribbler merged commit c2ef469 into nottinghamtec:master Oct 27, 2024
2 checks passed
@FreneticScribbler
Copy link
Member

Now watch the stochastic test suite fail on the second run through...

@FreneticScribbler
Copy link
Member

Was seeing a critical application error loading the dashboard yesterday - went to investigate today and it appears to no longer be occurring? Weird...

@jerbzz
Copy link
Contributor

jerbzz commented Nov 2, 2024

Stochastic in all respects

@jb3
Copy link
Member Author

jb3 commented Nov 2, 2024

Was seeing a critical application error loading the dashboard yesterday - went to investigate today and it appears to no longer be occurring? Weird...

I think this could be because I made the great application design decision of defaulting to all payments ever.

I'm going to swap it around to default to the smallest time period first and then I'll look at some query optimisation, this was just a starting point and there are some optimisations to be made to the ORM-generated SQL.

@FreneticScribbler
Copy link
Member

Average time to pay seems to be showing a slightly questionable number on the live data, as well?

@jb3
Copy link
Member Author

jb3 commented Nov 2, 2024

Average time to pay seems to be showing a slightly questionable number on the live data, as well?

This was also noticed the other day with Alfie. I think this is a technicality that internal SU payments are all attributed to the same day.

I'm going to break it down by payment method to hopefully get some more sensible data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants