Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show daily, weekly and monthly pomodoro history 🍅 #118

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gauravchl
Copy link
Contributor

screen shot 2017-08-20 at 4 37 50 pm

Uses node-storage to keep track of pomodoro history. Stores each pomodoro with it's start and end date.

cc: #113

@mojoaxel
Copy link
Collaborator

mojoaxel commented Mar 14, 2018

@gauravchl Thanks for contributing!

My problem is that this cool new feature would complicates the core.js even more. @notwaldorf and I would like to keep the project as easy and readable as possible. In the long run we should try to reduce complexity and not overload the core with new features.

What do you think about some kind of a plug-in system where we move all this weather and twitter stuff to seperate modules. Especially the pomodoro feature would be a nice candidate to reduce complexity!

At the moment I would prefer not to merge it 😿

Copy link
Collaborator

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pomodoro feature should be separated from the core to a new module.

@gauravchl
Copy link
Contributor Author

@mojoaxel

What do you think about some kind of a plug-in system

This is great, i like it.

Currently The Pomodoro logic is already inside pomodoro.js, some of the code related to Pomodoro inside care.js is(ie: key bindings...) just to provide connectivity between those two modules. I've some ideas to abstract Pomodoro feature further, will try those.

I'm thinking to use ES6 to improve code readability, structure and reduce some complexity. What do you think?

@mojoaxel
Copy link
Collaborator

I'm thinking to use ES6 to improve code readability, structure and reduce some complexity. What do you think?

I personally have no problem using ES6 but please make sure to enforce the needed node.js version in package.json and DON'T change the existing code to ES6. Just use it for new modules.

By the way: It is still @notwaldorf project and I'm not going to merge big changes without her approving them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants