Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error alert #96

Merged
merged 11 commits into from
Jul 19, 2024
Merged

Change error alert #96

merged 11 commits into from
Jul 19, 2024

Conversation

FerdinaKusumah
Copy link
Contributor

  • Remove error sweet alert and change to Jquery Toast
  • Create new file called component to initialize third party object

This for solving issue #94

@novalagung
Copy link
Owner

@FerdinaKusumah this is great, I'll take a look at it ASAP. thanks!

@novalagung
Copy link
Owner

@FerdinaKusumah thanks for the PR! I modified your code a little bit and added additional improvements to the UI when the data is being fetched. this should be good.

for safety reasons, I'll install this version on my local env and evaluate it for a couple of days. once everything is good, I will release new version

@novalagung
Copy link
Owner

nevermind, it looks good, releasing the build now. thanks a lot @FerdinaKusumah !

@novalagung novalagung merged commit 9dc68ba into novalagung:master Jul 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants