Dynamic xcm transfers detection #3020
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # chains/v20/chains_dev.json
# Conflicts: # chains/v21/chains_dev.json
stepanLav
reviewed
Dec 24, 2024
stepanLav
reviewed
Dec 24, 2024
stepanLav
reviewed
Dec 24, 2024
stepanLav
reviewed
Dec 24, 2024
stepanLav
reviewed
Dec 24, 2024
stepanLav
reviewed
Dec 24, 2024
stepanLav
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripts that should run periodically in CI:
find_working_directions.py- Does the main job and detects working transfers direction. Can be run as frequently as once in hour. Can also be run on PRs that modifyassetIdOverridesorassetsLocationfromchains_dynamic_*filessync_xcm_preliminary_data- pre-fetches some essential data like parachain ids, runtime prefix e.t.c. Alters contents ofxcm_registry_additional_data.json. Can be run less frequently as the content doesnt change often. Once a day seems like a reasonable periodManual & automatic changes
We still need to manually specify reserve locations for any new assets, as well as specify reserve id overrides in some exotic cases like "Statemine is reserve for relaychain asset". Everything else shoild be handled by the script