Remove Next.js, Yarn, Jest #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnthecat
force-pushed
the
tech/refactor
branch
from
e0e7931 to
f95b0a3
Compare
added 10 commits
June 17, 2024 13:00
sokolova-an
reviewed
Jun 17, 2024
There was a problem hiding this comment.
- What about dividing the routes into folders? This will make it easier to navigate when we have more screens
- Seams like in a web version
var(--tg-theme-button-color)doesn't apply so we have a bad color scheme (but it looks fine in the app) - All modals moved down, the tailwind style
--slide-exit: 80px;affected them - The loading screen now takes longer time and sometimes has glitches (see attachment)
- Looks like we're making too many requests to coingecko (without cashing), so it's easy to get
429 error - Too many requests
Screen.Recording.2024-06-17.at.19.04.49.mov
# Conflicts: # src/screens/onboarding/Onboarding.tsx # src/screens/onboarding/RestoreWallet.tsx
sokolova-an
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Moved from yarn to npm
yarn v1 is deprecated. We decided to move along with npm. For now it looks more stable and reliable.
Removed Next.js
Replaced Next.js with Vite + Remix. Main reason is to simplify app infrastructure and remove friction between app and third-party libs. Also, after Remix announced merging with react-router, next major release will remove any custom compilers and bring file-based routing as just another build feature in Vite config.
Moved tests from Jest to Vitest
Vitest have pretty much the same functionality as Jest, but removes additional configuration for test running.
Eslint
I've refactored Eslint config to make it more readable and speedup lint execution. Also, added some rules related to import ordering.
App refactoring
After working with Remix and build-in
React.StrictMode, i've found some nasty useEffects. They was rewritten.Precommit hooks
Added precommit hooks with typechecking, linting, and test running.
Serving
Added precompiled
gzipandbrotliassets for better user experience.Release preparation
NEXT_PUBLIC_*toPUBLIC_Aftermath
After these changes, we can start to rebuild Telenova as stable and easy-to-support app. Next steps most likely will be: