-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit: Added POJOS and API execution endpoint for WorkflowOverride API Integration #110
Merged
unicodeveloper
merged 8 commits into
novuhq:main
from
VishalMCF:featAdd-Java-SDK-methods-for-Workflow-Overrides-API
Jan 2, 2024
Merged
Initial commit: Added POJOS and API execution endpoint for WorkflowOverride API Integration #110
unicodeveloper
merged 8 commits into
novuhq:main
from
VishalMCF:featAdd-Java-SDK-methods-for-Workflow-Overrides-API
Jan 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishalMCF
changed the title
Initial commit: Added POJOS and API execution endpoint for WorkflowOverride API Integration #109
Initial commit: Added POJOS and API execution endpoint for WorkflowOverride API Integration
Dec 23, 2023
@unicodeveloper can you please review? |
mayorJAY
reviewed
Dec 29, 2023
src/main/java/co/novu/api/workflowoverrides/WorkflowOverrideApi.java
Outdated
Show resolved
Hide resolved
mayorJAY
reviewed
Dec 29, 2023
src/main/java/co/novu/api/workflowoverrides/WorkflowOverrideApi.java
Outdated
Show resolved
Hide resolved
mayorJAY
reviewed
Dec 29, 2023
src/main/java/co/novu/api/workflowoverrides/pojos/WorkflowOverride.java
Outdated
Show resolved
Hide resolved
mayorJAY
reviewed
Dec 29, 2023
@mayorJAY I have made the changes based on your comments. |
mayorJAY
reviewed
Dec 29, 2023
src/main/java/co/novu/api/workflowoverrides/pojos/WorkflowOverride.java
Outdated
Show resolved
Hide resolved
mayorJAY
reviewed
Dec 29, 2023
src/main/java/co/novu/api/workflowoverrides/WorkflowOverrideApi.java
Outdated
Show resolved
Hide resolved
mayorJAY
reviewed
Dec 29, 2023
src/main/java/co/novu/api/workflowoverrides/WorkflowOverrideApi.java
Outdated
Show resolved
Hide resolved
mayorJAY
reviewed
Dec 30, 2023
src/main/java/co/novu/api/workflowoverrides/WorkflowOverrideApi.java
Outdated
Show resolved
Hide resolved
mayorJAY
reviewed
Dec 31, 2023
src/main/java/co/novu/api/workflowoverrides/pojos/WorkflowOverride.java
Outdated
Show resolved
Hide resolved
mayorJAY
approved these changes
Dec 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Cliftonz Can this pull request be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
This change is to add a feature in the Java client SDK that adds all the methods supporting the WorkflowOverride API.
Tasks are done till now and need input -
Added methods for all the APIs in node packages.
Closes #109
Added the client class, test class, and updated the README.md file.