Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspicious Loop Detector #206

Merged
merged 24 commits into from
Jan 29, 2025
Merged

Suspicious Loop Detector #206

merged 24 commits into from
Jan 29, 2025

Conversation

Esorat
Copy link
Member

@Esorat Esorat commented Nov 3, 2024 •
edited
Loading

Closes #171

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented
  • No test failures were reported when running yarn test-all
  • I did not do unrelated and/or undiscussed refactorings

@jubnzv jubnzv changed the title WIP: Suspicious Loop Detector Suspicious Loop Detector Nov 4, 2024
@jubnzv jubnzv marked this pull request as draft November 4, 2024 10:25
@Esorat Esorat marked this pull request as ready for review January 5, 2025 13:20
jubnzv
jubnzv requested changes Jan 23, 2025
View reviewed changes
test/detectors/NeverAccessedVariables.tact Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Esorat Esorat requested a review from jubnzv January 25, 2025 05:16
@Esorat Esorat requested a review from jubnzv January 26, 2025 04:46
jubnzv
jubnzv requested changes Jan 26, 2025
View reviewed changes
src/detectors/builtin/suspiciousLoop.ts Outdated Show resolved Hide resolved
test/detectors/SuspiciousLoop.tact Outdated Show resolved Hide resolved
jubnzv
jubnzv requested changes Jan 27, 2025
View reviewed changes
src/detectors/builtin/suspiciousLoop.ts Outdated Show resolved Hide resolved
src/detectors/builtin/suspiciousLoop.ts Outdated Show resolved Hide resolved
src/detectors/builtin/suspiciousLoop.ts Outdated Show resolved Hide resolved
test/detectors/NeverAccessedVariables.tact Outdated Show resolved Hide resolved
@Esorat
FIX: Remove warning for large numeric comparisons in loops; Restrict …
c7efc19 
…"always false" warning to while loops with non-empty body; Preserve infinite loop and high-cost repeat warnings. Update expected output;
@Esorat Esorat requested a review from jubnzv January 29, 2025 10:30
@jubnzv jubnzv merged commit 9cf3700 into nowarp:master Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubnzv jubnzv Awaiting requested review from jubnzv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suspicious Loop
2 participants
@Esorat @jubnzv