i18n, add chinese lang #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noworneverev
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Thank you so much for your efforts! Here are a few changes and suggestions:
- Please add a switch button in the header to allow users to choose the language, with English set as the default.
- Kindly add back the Google Analytics measurement.
- Additional minor suggestions are provided in the separate comments.
| Please enable "Include Text Unit" and "Include Communities" | ||
| {hasCovariates && ', and "Include Covariates"'} to use Local | ||
| Search. | ||
| {t('apiSearchDrawer.enableLocalSearch', { hasCovariates })} |
There was a problem hiding this comment.
This needs to be fixed. The intention is that when users upload a covariate parquet file, 'hasCovariate' will be set to true. Therefore, displaying this label will be meaningful.
|
|
||
| i18n.use(initReactI18next) | ||
| .init({ | ||
| lng: 'zh-Hans', |
There was a problem hiding this comment.
Please set the default language to English.
| @@ -46,3 +46,20 @@ The logic for creating relationships for text units, documents, communities, and | |||
| | Text Unit | `HAS_COVARIATE` | Covariate | | |||
| | Community | `HAS_FINDING` | Finding | | |||
| | Entity | `IN_COMMUNITY` | Community | | |||
|
|
|||
|
|
|||
| ## | |||
There was a problem hiding this comment.
Please add a title here, e.g., ## Docker Setup.
| import { initReactI18next } from 'react-i18next' | ||
|
|
||
| import data from './languages.json' | ||
| import Introduction from '@/app/components/Introduction'; |
| @@ -64,13 +76,59 @@ const GraphDataHandler: React.FC = () => { | |||
| }, [entities]); | |||
|
|
|||
| useEffect(() => { | |||
| const measurementId = process.env.REACT_APP_GA_MEASUREMENT_ID; | |||
There was a problem hiding this comment.
Please add back the Google Analytics measurement. We still need it for tracking purposes.
| }); | ||
|
|
||
|
|
||
| const GraphDataHandler: React.FC<{ categary: string|null }> = ({ categary }) => { |
There was a problem hiding this comment.
Typo: 'categary' should be 'category'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i18n, add chinese lang