user-install: Make use of the R2PM_MANDIR variable. #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trufae
reviewed
Feb 17, 2025
| @@ -91,6 +91,7 @@ LDFLAGS+=$(shell pkg-config --libs r_core r_io r_util) | |||
| endif | |||
| R2_BINDIR=$(shell r2 -H R2_PREFIX)/bin | |||
| R2PM_BINDIR=$(shell r2pm -H R2PM_BINDIR) | |||
| R2PM_MANDIR=$(shell r2pm -H R2PM_MANDIR) | |||
There was a problem hiding this comment.
Check if var is “” and set a default value because this should work with older versions of r2 too
There was a problem hiding this comment.
I've added this in 845640b
Will ensure a legit value is used even when an old r2pm is being used to install the plugin.
|
I've canonicalized the paths using |
teasp00n
force-pushed
the
install-manpage-without-sudo
branch
from
543caf7 to
845640b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of the new
R2PM_MANDIRvariable exposed byr2pm.Relies on code changes in radareorg/radare2#23963
See the NOTE in that MR for an explanation on how man pages in this location will actually be discovered.