Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ToString for logging name #29

Merged
merged 1 commit into from
Mar 8, 2025
Merged

Fix ToString for logging name #29

merged 1 commit into from
Mar 8, 2025

Conversation

nowsprinting
Copy link
Owner

No description provided.

@Copilot Copilot bot review requested due to automatic review settings March 8, 2025 00:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the output of the ToString method for logging in RandomWrapper and RandomImpl to use the wording "includes System.Random" instead of "using System.Random".

  • Updates the expected log message in the test file.
  • Modifies the ToString implementations in RandomWrapper and RandomImpl to reflect the new message.

Reviewed Changes

File Description
Tests/Runtime/RandomWrapperTestToUseInsteadOfUnityEngineRandom.cs Updated test to expect the new log message wording.
Runtime/RandomWrapper.cs Modified ToString method to output "includes System.Random" for logging.
Runtime/RandomImpl.cs Modified ToString method to output "includes System.Random" for logging.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Copy link

github-actions bot commented Mar 8, 2025

Code Metrics Report

master (813e41e) #29 (484b019) +/-
Coverage 44.5% 44.5% 0.0%
Code to Test Ratio 1:0.7 1:0.7 0.0
Test Execution Time 5m28s 3m4s -2m24s
Details
  |                     | master (813e41e) | #29 (484b019) |  +/-   |
  |---------------------|------------------|---------------|--------|
  | Coverage            |            44.5% |         44.5% |   0.0% |
  |   Files             |                3 |             3 |      0 |
  |   Lines             |              119 |           119 |      0 |
  |   Covered           |               53 |            53 |      0 |
  | Code to Test Ratio  |            1:0.7 |         1:0.7 |    0.0 |
  |   Code              |              271 |           271 |      0 |
  |   Test              |              208 |           208 |      0 |
+ | Test Execution Time |            5m28s |          3m4s | -2m24s |

Code coverage of files in pull request scope (31.9% → 31.9%)

Files Coverage +/-
Runtime/RandomImpl.cs 0.0% 0.0%
Runtime/RandomWrapper.cs 56.3% 0.0%

Reported by octocov

@nowsprinting nowsprinting merged commit 010f3a3 into master Mar 8, 2025
15 checks passed
@nowsprinting nowsprinting deleted the fix_logging branch March 8, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant