Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to @primer/react #767

Merged
merged 76 commits into from
Oct 23, 2023
Merged

Migrate to @primer/react #767

merged 76 commits into from
Oct 23, 2023

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Oct 16, 2023 •
edited
Loading

This also merges the theme/ directory into the root since there is not a reason to keep it separate now that it is all in one repo. This removes the file shadowing that is possible with Gatsby themes, as well as us needing to support passing options to the theme. This PR also attempt to remove any dead code found during this migration.

  • Remove prettier from cli workspace
  • Add content to 404 page
  • Pages with code blocks dont resize properly
  • Change sidebar spacing/text size
  • code blocks have extra new line
  • code blocks are not syntax highlighted
Code Block Screenshot

image

Resize Screenshot

Screenshot 2023-10-17 at 10 50 58 AM

Closes #765
Closes #764
Closes #738
Closes #734
Closes #772
Closes #770
Closes #760

@lukekarrys lukekarrys force-pushed the lk/dev-speed branch 2 times, most recently from d8280a5 to a603d54 Compare October 16, 2023 16:40
@lukekarrys lukekarrys mentioned this pull request Oct 16, 2023
Closed
@lukekarrys lukekarrys changed the title lk/dev speed Migrate to @primer/react Oct 16, 2023
@lukekarrys lukekarrys marked this pull request as ready for review October 17, 2023 03:31
@lukekarrys lukekarrys requested review from MylesBorins, monishcm and a team as code owners October 17, 2023 03:31
@lukekarrys lukekarrys temporarily deployed to github-pages October 17, 2023 15:55 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 17, 2023 16:17 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 17, 2023 17:12 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 17, 2023 19:28 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 17, 2023 21:17 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 17, 2023 22:15 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 17, 2023 22:24 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 17, 2023 23:04 — with GitHub Actions Inactive
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 18, 2023
View reviewed changes
cli/lib/transform.js Dismissed Show dismissed Hide dismissed
@lukekarrys lukekarrys temporarily deployed to github-pages October 18, 2023 13:48 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 18, 2023 18:59 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 18, 2023 19:46 — with GitHub Actions Inactive
@lukekarrys lukekarrys force-pushed the lk/dev-speed branch 3 times, most recently from 0707937 to ea685a4 Compare October 19, 2023 23:42
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 19, 2023
View reviewed changes
cli/lib/extract.js Fixed Show fixed Hide fixed
cli/lib/extract.js Fixed Show fixed Hide fixed
@lukekarrys lukekarrys temporarily deployed to github-pages October 19, 2023 23:52 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 22, 2023 06:33 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 22, 2023 07:06 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 22, 2023 07:21 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 22, 2023 15:27 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 22, 2023 18:21 — with GitHub Actions Inactive
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 22, 2023
View reviewed changes
cli/lib/extract.js Dismissed Show dismissed Hide dismissed
@lukekarrys lukekarrys temporarily deployed to github-pages October 22, 2023 20:39 — with GitHub Actions Inactive
@lukekarrys
Fix GFM features in mdx
5220b7e 
Also turn on linting for mdx files and fix errors
@lukekarrys lukekarrys temporarily deployed to github-pages October 22, 2023 23:03 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 23, 2023 00:03 — with GitHub Actions Inactive
@lukekarrys lukekarrys temporarily deployed to github-pages October 23, 2023 03:49 — with GitHub Actions Inactive
@lukekarrys lukekarrys merged commit c62df53 into main Oct 23, 2023
11 checks passed
@lukekarrys lukekarrys deleted the lk/dev-speed branch October 23, 2023 05:39
This was referenced Oct 23, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

@monishcm monishcm Awaiting requested review from monishcm monishcm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@lukekarrys