-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds type #313
feat: adds type #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change!
failing because I added package-json 6.1.0 manually waiting for npm/package-json#134 |
It only affects manually entered things, which usually isn't something we include in the semver contract. Only programmatic things. If someone were already using this programmatically would things not work where they did before? |
@wraithgar nope I don't think so, at least not though intended means |
I don't think it is then. We'll be bumping engines here so we are gonna be doing a semver major anyways. We can change the first commit to a normal |
🤖 I have created a release *beep* *boop* --- ## [8.0.0](v7.0.2...v8.0.0) (2024-12-02) ###⚠️ BREAKING CHANGES * this module is now compatible with the following node versions: ^20.17.0 || >=22.9.0 * adds a new `type` prompt and changes the sort order of created packages ### Features * [`5eeea50`](5eeea50) [#313](#313) adds type, sorting (#313) (@reggi) ### Bug Fixes * [`f4c1430`](f4c1430) update node engines to ^20.17.0 || >=22.9.0 (#318) (@wraithgar) ### Chores * [`47339ef`](47339ef) [#311](#311) bump @npmcli/config from 8.3.4 to 9.0.0 (#311) (@dependabot[bot]) * [`2ccbf30`](2ccbf30) [#310](#310) bump @npmcli/template-oss from 4.23.3 to 4.23.4 (#310) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Adds
type
topackage.json
for use when runningnpm init
.commonjs
commonjs
|module
npm init --init-type module -y
init.type=module
in.npmrc
on the shoulders of #302
a part of the npm 11 roadmap npm/statusboard#898
statusboard issue here npm/statusboard#654
older rfc npm/rfcs#347