fix: autolocation of node-gyp in make-spawn-args

[legobeat]

• Prevents runtime error in environments where require.resolve is not available.
• Fall back to environment variable npm_config_node_gyp when node-gyp not resolved successfully.

Related

• [BUG] The npm_config_node_gyp environment variable and npm config set node-gyp config don't work with npm 7 #23
• [BUG] config var "node-gyp" not respected in npm 7 cli#2839

[legobeat]

The typeof require may seem redundant here considering we call require('path') just prior.

Rightfully or not, bundlers like webpack and esbuild may transform the direct require() calls but leave require.resolve intact. The extra check prevents runtime errors in such scenarios.

[wraithgar]

I think for now we need the runtime error here. If this isn't working then this module shouldn't think it is working.

run-script/lib/node-gyp-bin/node-gyp

Line 2 in a8b4034

node "$npm_config_node_gyp" "$@"

[legobeat]

@reggi @hashtagchris Some attention on this and #222 would be much appreciated if you are able to 🙏

[wraithgar]

This seems like it is a breaking change and I think we should not land this right now. Now that node-gyp is a proper config in npm we can look into untangling this magic that existed here, and make this something that the cli drives, and that users pass in explicitly if they want it (as npm will be doing).

Let's land npm/cli#8129, then I can update #222 to gracefully handle that param, and we can go from there.