Fix #1253: RZ codes IAEA phase-space particle charge not used #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missing initialization of variables for IAEA phase-spaces in the RZ codes. While this didn't result in a crash, it did result in a bug where all particles were assigned a charge of 0 during the transport.
rtownson
force-pushed
the
fix-rz-iaea-phsp
branch
from
55fef77 to
450676c
Compare
3 tasks
|
There is only one file modified. I couldn't find the macro making the initialization. |
mainegra
approved these changes
Feb 18, 2025
blakewalters
approved these changes
Feb 18, 2025
ftessier
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a critical bug in the RZ codes when using IAEA phase-space sources. All particles from the phase-space were assigned to be photons, due to a missing initialisation of some phase-space related variables. This bug affects all RZ code simulations using IAEA phase-space sources with particles other than photons. I believe the bug has existed since earlier than 2015.
Big thanks to @yamane89 for reporting the issue: #1253