SonarQube findings resolution - WIP - DO NOT REVIEW YET, DO NOT MERGE #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adsz-nordic
force-pushed
the
ncsdk-35334
branch
from
84e95a5 to
5ce7e3d
Compare
"volatile" types should not be used in compound operations Issue link: https://sonarcloud.io/project/issues?open=AZWum4f1vizSu0tgQ8GT&id=nrfconnect_sdk-mcuboot Ref: NCSDK-35334 Signed-off-by: Adam Szczygieł <[email protected]>
Accessing sequence elements should not trigger an IndexError. Issue link: https://sonarcloud.io/project/issues?open=AZedPVgw78lmM2RicPGW&id=nrfconnect_sdk-mcuboot Ref: NCSDK-35334 Signed-off-by: Adam Szczygieł <[email protected]>
Identical sub-expressions on both sides of operator "||". Issue link: https://sonarcloud.io/project/issues?open=AZWum43evizSu0tgQ8Kq&id=nrfconnect_sdk-mcuboot Ref: NCSDK-35334 Signed-off-by: Adam Szczygieł <[email protected]>
Access of 'unsigned char' element in 'buf' at an overflowing index Issue link: https://sonarcloud.io/project/issues?open=AZWum4_vvizSu0tgQ8Mw&id=nrfconnect_sdk-mcuboot Ref: NCSDK-35334 Signed-off-by: Adam Szczygieł <[email protected]>
adsz-nordic
force-pushed
the
ncsdk-35334
branch
from
5ce7e3d to
b0f9777
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT REVIEW, DO NOT MERGE - attempt to launch SonarQube checks for evaluation of proposed fixes.
More changes are about to be made - work in progress...