Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcuboot: multi-image: Multi Image DFU without external flash #10060

Closed
wants to merge 1 commit into from
Closed

mcuboot: multi-image: Multi Image DFU without external flash #10060

wants to merge 1 commit into from

Conversation

sigvartmh
Copy link
Contributor

Added the possibility to use Multi Image DFU on nRF53 without external flash.

Ref. NCSDK-12809

Signed-off-by: Sigvart Hovland [email protected]

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest labels Jan 25, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 25, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
mcuboot nrfconnect/sdk-mcuboot@a9d5fa7 (main) nrfconnect/sdk-mcuboot#235 nrfconnect/sdk-mcuboot#235/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch from ea05960 to 8763774 Compare January 25, 2023 16:17
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 25, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-apps X
test-fw-nrfconnect-ble X
test-fw-nrfconnect-ble_mesh X
test-fw-nrfconnect-ble_samples X
test-fw-nrfconnect-boot X
test-fw-nrfconnect-chip X
test-fw-nrfconnect-fem X
test-fw-nrfconnect-fw-update X
test-fw-nrfconnect-nfc X
test-fw-nrfconnect-nrf-iot_cloud X
test-fw-nrfconnect-nrf-iot_libmodem-nrf X
test-fw-nrfconnect-nrf-iot_lwm2m X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_nrf_provisioning X X
test-fw-nrfconnect-nrf-iot_positioning X
test-fw-nrfconnect-nrf-iot_samples X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_thingy91 X
test-fw-nrfconnect-nrf-iot_zephyr_lwm2m X
test-fw-nrfconnect-nrf_crypto X
test-fw-nrfconnect-proprietary_esb X
test-fw-nrfconnect-rpc X
test-fw-nrfconnect-rs X
test-fw-nrfconnect-tfm X
test-fw-nrfconnect-thread X
test-fw-nrfconnect-zigbee X
test-sdk-audio X
test-sdk-find-my X
test-sdk-pmic-samples X
test-sdk-sidewalk X
test-sdk-wifi X

All integration tests: null

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

hakonfam
hakonfam requested changes Jan 26, 2023
View reviewed changes
doc/nrf/releases/release-notes-changelog.rst Outdated Show resolved Hide resolved
subsys/partition_manager/Kconfig Outdated Show resolved Hide resolved
subsys/partition_manager/Kconfig Outdated Show resolved Hide resolved
@sigvartmh sigvartmh added this to the 2.3.0 milestone Jan 30, 2023
@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch from df875fb to ef5e547 Compare January 30, 2023 12:26
@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch 3 times, most recently from 2b07cbc to dfee3b3 Compare February 2, 2023 15:47
FrancescoSer
FrancescoSer approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@FrancescoSer FrancescoSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but please implement the last suggestion

doc/nrf/releases/release-notes-changelog.rst Outdated Show resolved Hide resolved
@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch 2 times, most recently from 9a4139a to 6e24a4b Compare February 14, 2023 12:59
@sigvartmh
Copy link
Contributor Author

JlinkError on CHIP test and Java error on nRF Cloud IoT test. I can't be bothered re-running CI if it keeps being broken.

@tmon-nordic
Copy link
Contributor

JlinkError on CHIP test and Java error on nRF Cloud IoT test. I can't be bothered re-running CI if it keeps being broken.

That's unfortunate. However you should chase the reviewers on sdk-mcuboot PR because without it reviewed, this cannot go in.

@sigvartmh sigvartmh self-assigned this Feb 15, 2023
@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch from 6e24a4b to dd67e3a Compare February 15, 2023 21:16
@shantha-14 shantha-14 removed this from the 2.3.0 milestone Feb 16, 2023
@shantha-14
Copy link

removed milestone as agreed with @sigvartmh

@sigvartmh sigvartmh added this to the 2.4.0 milestone Mar 20, 2023
@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch from dd67e3a to 4da4a3b Compare March 20, 2023 10:53
@osaether osaether removed this from the 2.4.0 milestone May 15, 2023
@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch 3 times, most recently from a8f260a to 183e30d Compare June 12, 2023 12:00
@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch from 183e30d to 3c3f0b7 Compare June 23, 2023 08:43
@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch 2 times, most recently from 9ae8ee7 to eb4156b Compare July 19, 2023 08:21
@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch from eb4156b to 63cbe59 Compare July 31, 2023 08:27
@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch 3 times, most recently from f3048b3 to d1fc93b Compare August 11, 2023 11:45
@sigvartmh sigvartmh added this to the 2.5.0 milestone Aug 11, 2023
@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch 2 times, most recently from 2785612 to 2076356 Compare August 22, 2023 11:53
@de-nordic de-nordic requested a review from nordicjm August 22, 2023 23:28
nordicjm
nordicjm requested changes Aug 24, 2023
View reviewed changes
subsys/partition_manager/Kconfig
@@ -182,11 +182,26 @@ config PM_EXTERNAL_FLASH_MCUBOOT_SECONDARY
# option is propagated to the MCUboot child image automatically.
depends on PM_EXTERNAL_FLASH_ENABLED || MCUBOOT
default y if BOOTLOADER_MCUBOOT
imply PM_EXTERNAL_FLASH_MCUBOOT_SECONDARY_1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like @tejlmand to comment on this from a sysbuild perspective, how can this be used from sysbuild since these do not apply

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how sysbuild handles putting things in external flash to be honest. I'm a bit out of the loop on the whole sysbuild system also :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sigvartmh @tejlmand @nordicjm Can you find an agreement here?

@osaether osaether removed this from the 2.5.0 milestone Oct 12, 2023
@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch from 2076356 to 6ca3039 Compare November 17, 2023 13:47
@sigvartmh sigvartmh requested a review from de-nordic as a code owner November 17, 2023 13:47
@sigvartmh sigvartmh added this to the 2.6.0 milestone Nov 17, 2023
@shanthanordic
Copy link

@sigvartmh could you do a force push and rerun the tests ?

@sigvartmh
mcuboot: multi-image: Multi Image DFU without external flash
2124d41 
Added the possibility to use Multi Image DFU on nRF53 without external
flash.

Ref. NCSDK-12809

Signed-off-by: Sigvart Hovland <[email protected]>
@sigvartmh sigvartmh force-pushed the feature/multi-image-dfu-without-external-flash branch from 6ca3039 to 2124d41 Compare February 8, 2024 13:15
@SeppoTakalo
Copy link
Contributor

Is this really relevant for 2.6.0?
The PR have been open for a year?

@sigvartmh
Copy link
Contributor Author

sigvartmh commented Feb 15, 2024 •
edited
Loading

I'm okay with closing this one; I haven't seen anyone requesting this feature for some time. This PR enables users to use multi-image DFU on nRF91/53/52 without external flash, leaving you with very little flash space on the device.

It seems it's crashing for some IoT 91 tests also and I don't feel confident to pin point where these tests are failing.

@jfischer-no
Copy link
Contributor

I'm okay with closing this one; I haven't seen anyone requesting this feature for some time. This PR enables users to use multi-image DFU on nRF91/53/52 without external flash, leaving you with very little flash space on the device.

It seems it's crashing for some IoT 91 tests also and I don't feel confident to pin point where these tests are failing.

Then close or remove the milestone tag.

@SeppoTakalo SeppoTakalo removed this from the 2.6.0 milestone Feb 21, 2024
@sigvartmh sigvartmh closed this May 30, 2024
@dman82499
Copy link

I'm okay with closing this one; I haven't seen anyone requesting this feature for some time. This PR enables users to use multi-image DFU on nRF91/53/52 without external flash, leaving you with very little flash space on the device.

It seems it's crashing for some IoT 91 tests also and I don't feel confident to pin point where these tests are failing.

I actually would like to request this feature, we are currently using a 5340 but would like to use our external flash entirely for storage.

@tomasMjp
Copy link

tomasMjp commented Oct 2, 2024

Hello, I need this feature too. We have a custom appcore and netcore application that uses an small amount of flash, so we don't need external flash.
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordicjm nordicjm nordicjm requested changes

@FrancescoSer FrancescoSer FrancescoSer approved these changes

@tejlmand tejlmand Awaiting requested review from tejlmand

@carlescufi carlescufi Awaiting requested review from carlescufi

@hakonfam hakonfam Awaiting requested review from hakonfam

@de-nordic de-nordic Awaiting requested review from de-nordic

Assignees

@sigvartmh sigvartmh

Labels
DNM doc-required PR must not be merged without tech writer approval. manifest manifest-mcuboot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.