Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: crypto: psa_tls support for TLSv1.3 #18993

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

PFnord
Copy link
Contributor

@PFnord PFnord commented Nov 20, 2024

Allow the use of TLS1.3 in nrf samples with nrf_security and nrf_config (instead of mbedtls default config file)

Added tests for oberon, cc3xx_oberon and cracen backend for the psa_tls sample

@PFnord PFnord requested review from a team as code owners November 20, 2024 13:59
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 20, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 20, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 17

Inputs:

Sources:

sdk-nrf: PR head: 862325de5f1a5537002f8c78e079c41c304cfc68

more details

sdk-nrf:

PR head: 862325de5f1a5537002f8c78e079c41c304cfc68
merge base: 13b17afba152e3b936d6cbe87fe11fa3d0f7a885
target head (main): 91bd16d2ea1c2aaca18c97e2bba55d649553b7a9
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (8)
samples
│  ├── crypto
│  │  ├── psa_tls
│  │  │  ├── overlays
│  │  │  │  ├── cracen-oberon-psa.conf
│  │  │  │  │ tls_1_3.conf
│  │  │  ├── sample.yaml
│  │  │  ├── src
│  │  │  │  ├── psa_tls_functions_client.c
│  │  │  │  │ psa_tls_functions_server.c
subsys
│  ├── nrf_security
│  │  ├── Kconfig.tls
│  │  ├── cmake
│  │  │  │ nrf_config.cmake
│  │  ├── configs
│  │  │  │ nrf-config.h.template

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 1619
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-sdk-find-my
    • ✅ test-sdk-sidewalk
    • ✅ test-sdk-dfu
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
Disabled integration tests
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@PFnord PFnord force-pushed the tls13_tests branch 3 times, most recently from 2b90d44 to 27f6128 Compare November 20, 2024 15:11
@PFnord PFnord changed the title samples: psa_tls support for TLSv1.3 samples: crypto: psa_tls support for TLSv1.3 Nov 20, 2024
@@ -108,6 +145,30 @@ tests:
- nrf54l15dk/nrf54l15/cpuapp
- nrf54l15pdk/nrf54l15/cpuapp
tags: ci_build oberon sysbuild ci_samples_crypto
sample.psa_tls.1_3_server.ecdsa.oberon:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you meant ...sample.psa_tls.tls_1_3_server.. (that's what I see in the previous sample)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the paths for 54l15 samples were made different, I just followed the naming scheme from before: tls_server -> tls_1_3_server and server -> 1_3_server

subsys/nrf_security/Kconfig.tls Outdated Show resolved Hide resolved
subsys/nrf_security/Kconfig.tls Show resolved Hide resolved
subsys/nrf_security/Kconfig.tls Outdated Show resolved Hide resolved
subsys/nrf_security/Kconfig.tls Outdated Show resolved Hide resolved
subsys/nrf_security/Kconfig.tls Outdated Show resolved Hide resolved
subsys/nrf_security/Kconfig.tls Outdated Show resolved Hide resolved
subsys/nrf_security/Kconfig.tls Outdated Show resolved Hide resolved
subsys/nrf_security/Kconfig.tls Outdated Show resolved Hide resolved
subsys/nrf_security/cmake/nrf_config.cmake Outdated Show resolved Hide resolved
subsys/nrf_security/configs/nrf-config.h.template Outdated Show resolved Hide resolved
subsys/nrf_security/cmake/nrf_config.cmake Outdated Show resolved Hide resolved
subsys/nrf_security/Kconfig.tls Outdated Show resolved Hide resolved
subsys/nrf_security/Kconfig.tls Outdated Show resolved Hide resolved
samples/crypto/psa_tls/sample.yaml Outdated Show resolved Hide resolved
samples/crypto/psa_tls/src/psa_tls_functions_client.c Outdated Show resolved Hide resolved
@@ -12,9 +12,14 @@ tests:
extra_args: >
OVERLAY_CONFIG="overlays/server.conf;overlays/ecdsa.conf;overlays/cc3xx-oberon-psa.conf"
platform_allow: >
Copy link
Contributor

@tomi-font tomi-font Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/platform_allow: >/platform_allow:/

@PFnord PFnord requested a review from tomi-font December 11, 2024 14:00
@PFnord PFnord force-pushed the tls13_tests branch 3 times, most recently from 79c9a93 to e10cbc1 Compare December 11, 2024 15:41
@PFnord PFnord force-pushed the tls13_tests branch 2 times, most recently from be9191e to 8e0ddd6 Compare December 12, 2024 14:08
Added TLSv1.3 overlay for psa_tls sample and tests for different
backends

Signed-off-by: Paul Fleury <[email protected]>
@nordicjm nordicjm merged commit a6d5317 into nrfconnect:main Dec 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants