-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applications: sdp: mspi: Initial implementation #19077
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: e2fc7e80e7b5f39f92c739fc898ae6417bb1501f more detailssdk-nrf:
Github labels
List of changed files detected by CI (11)
Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
applications/sdp/mspi/boards/nrf54l15dk_nrf54l15_cpuflpr_icmsg.overlay
Outdated
Show resolved
Hide resolved
applications/sdp/mspi/boards/nrf54l15dk_nrf54l15_cpuflpr_mbox.overlay
Outdated
Show resolved
Hide resolved
89779ab
to
46c2f4d
Compare
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the configuration and IPC part.
Will this be added in a separate PR?
6db8c81
to
404b685
Compare
@nordicjm Can you take a look at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-- Using ccache: /usr/bin/ccache
CMake Warning at /tmp/bb/zephyr/CMakeLists.txt:952 (message):
No SOURCES given to Zephyr library: drivers__mbox
Excluding target from build.
CMake Warning (dev) at /tmp/bb/nrf/cmake/sdp.cmake:39 (add_custom_command):
The following keywords are not supported when using
add_custom_command(TARGET): DEPENDS.
Policy CMP0175 is not set: add_custom_command() rejects invalid arguments.
Run "cmake --help-policy CMP0175" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
Call Stack (most recent call first):
CMakeLists.txt:12 (sdp_assembly_generate)
This warning is for project developers. Use -Wno-dev to suppress it.
CMake Warning (dev) at /tmp/bb/nrf/cmake/sdp.cmake:39 (add_custom_command):
Exactly one of PRE_BUILD, PRE_LINK, or POST_BUILD must be given. Assuming
POST_BUILD to preserve backward compatibility.
Policy CMP0175 is not set: add_custom_command() rejects invalid arguments.
Run "cmake --help-policy CMP0175" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
Call Stack (most recent call first):
CMakeLists.txt:12 (sdp_assembly_generate)
This warning is for project developers. Use -Wno-dev to suppress it.
-- Configuring done (7.7s)
-- Generating done (0.1s)
this needs fixing
I don't understand what the intention here is with this, should the .s file be present? Shouldn't it be generated by the build itself? If I build the application then run the asm_install command I get a completely different file e.g.
|
bbacf51
to
17bf877
Compare
ebee9f9
to
f910c03
Compare
@nordicjm How did you get this log, I'm not seing these warnings while building project |
Using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there are still a few comments from Magda to take care of.
6ece761
to
7a16741
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits. but cmake warnings are gone
Apply comments throughout (only first instances were highlighted) |
bf204ce
to
7c327f9
Compare
699ab5c
to
3c2d40a
Compare
Added initial mspi implementation with hard real time task running on interrupts. Signed-off-by: Michal Frankiewicz <[email protected]> Signed-off-by: Magdalena Pastula <[email protected]>
3c2d40a
to
e2fc7e8
Compare
Added initial mspi implementation with hard real time task running on interrupts.