-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: Fix Wi-Fi and BLE combo radio test for 54H #19149
Conversation
@57300 for combo build I reverted your changes, but not sure if the SR radio test still works with using DMA region of RAD, please review. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 499427d45a8a27aec52cba13a0166b98c4651a2c more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)
Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
ca9c9c2
to
19437ac
Compare
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@57300 for combo build I reverted your changes, but not sure if the SR radio test still works with using DMA region of RAD, please review.
I can't really comment on that. I assume you're referring to the changes in a9543c9, which I added as a replacement for 2ec2653. Maybe someone else can elaborate on potential issues with the DMA region being too small (cc @nordic-piks) or why the peripheral radio test sample needs to use uart136
, as opposed to uart135
, which is default for cpurad
.
Regarding DMA regions - please ask @nika-nordic - he proposed solution at [2ec2653] |
19437ac
to
20c8d49
Compare
When a combo radio test is used for 54H, the peripheral radio test uses the same console as Wi-Fi radio test causing UICR conflicts and failing to boot both APP and RAD. Fix the conflicts by adding an overlay that uses defaults. Fixes SHEL-3287. Signed-off-by: Chaitanya Tata <[email protected]>
20c8d49
to
499427d
Compare
@nrfconnect/ncs-si-muffin ping. |
@pdunaj can someone from Muffin please review this PR? |
Done, I wonder if muffin should at all be engaged in this samples if these are wifi related. |
When a combo radio test is used for 54H, the peripheral radio test uses the same console as Wi-Fi radio test causing UICR conflicts and failing to boot both APP and RAD.
Fix the conflicts by adding an overlay to use a separate console and also not to use APP RAM in RAD.
Fixes SHEL-3287.