Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snippets: Remove the L05 and L10 emulation snippets #19162

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

carlescufi
Copy link
Contributor

The nRF54L05 and the nRF54L10 are now natively supported in NCS, as their own SoCs and as emulated targets in the nRF54L15 DK board. There is no longer need for those snippets.

@carlescufi carlescufi requested review from annwoj and a team as code owners November 29, 2024 13:23
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 29, 2024
@carlescufi carlescufi added this to the 2.9.0 milestone Nov 29, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 29, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 54d11922ef28f682332e5b179b12d3875ad65182

more details

sdk-nrf:

PR head: 54d11922ef28f682332e5b179b12d3875ad65182
merge base: 5fdb7fd294275190c48825e12578260c335b917d
target head (main): bffb2a6db56e7f12785f2ffd97ebe52f67b34c32
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (9)
doc
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── device_guides
│  │  │  │  ├── nrf54l
│  │  │  │  │  ├── index.rst
│  │  │  │  │  │ snippets.rst
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-2.8.0.rst
snippets
│  ├── emulated-nrf54l05
│  │  ├── README.rst
│  │  ├── boards
│  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │ snippet.yml
│  ├── emulated-nrf54l10
│  │  ├── README.rst
│  │  ├── boards
│  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │ snippet.yml

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 46
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@@ -69,4 +69,3 @@ Ensure to check the revision of your nRF54L15 device to see if it is supported:
testing_dfu
vpr_flpr
building_nrf54l
snippets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, on this page the references to snippets have to be removed (lines 29 and 34)

Copy link
Contributor

@divipillai divipillai Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, we could keep this as text for now, and once doc pages are available in the down stream - zephyrproject-rtos/zephyr#82298, we could add this link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @annwoj and @divipillai, please take another look now.

@carlescufi carlescufi force-pushed the remove-snippets-l05-l10 branch from 5ce8267 to d9319f8 Compare December 4, 2024 09:56
@carlescufi carlescufi requested a review from a team as a code owner December 4, 2024 09:56
The nRF54L05 and the nRF54L10 are now natively supported in NCS, as
their own SoCs and as emulated targets in the nRF54L15 DK board. There
is no longer need for those snippets.

Signed-off-by: Carles Cufi <[email protected]>
@carlescufi carlescufi force-pushed the remove-snippets-l05-l10 branch from d9319f8 to 54d1192 Compare December 4, 2024 10:36
@carlescufi carlescufi requested a review from a team as a code owner December 4, 2024 10:36
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@carlescufi carlescufi merged commit d126a9c into nrfconnect:main Dec 4, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants