Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Move Thingy:91 and Thingy:91 x under application development #19202

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

divipillai
Copy link
Contributor

@divipillai divipillai commented Dec 2, 2024

Moved Thingy:91 and Thingy:91 x under application development.

NCSDK-29643

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 2, 2024
@divipillai divipillai added CI-disable Disable CI for this PR changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 2, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 2, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 12

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests

Note: This message is automatically posted and updated by the CI

@divipillai divipillai force-pushed the appdev_thingy91 branch 5 times, most recently from 48db07c to 06692e7 Compare December 3, 2024 11:41
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 3, 2024
@divipillai divipillai force-pushed the appdev_thingy91 branch 3 times, most recently from 3b31610 to 568459b Compare December 3, 2024 15:55
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@divipillai divipillai marked this pull request as ready for review December 3, 2024 16:57
@divipillai divipillai requested review from a team as code owners December 3, 2024 16:57
@divipillai divipillai modified the milestone: 2.9.0 Dec 4, 2024
doc/nrf/app_dev/device_guides/thingy91/index.rst Outdated Show resolved Hide resolved
doc/nrf/app_dev/device_guides/thingy91x/index.rst Outdated Show resolved Hide resolved
doc/_zoomin/ncs.tags.yml Outdated Show resolved Hide resolved
doc/_zoomin/ncs.tags.yml Outdated Show resolved Hide resolved
doc/_zoomin/ncs.tags.yml Outdated Show resolved Hide resolved
@divipillai divipillai force-pushed the appdev_thingy91 branch 2 times, most recently from 896e673 to 3cec3e3 Compare December 5, 2024 07:35
@divipillai divipillai requested a review from a team as a code owner December 5, 2024 07:35
Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the doc preview and it looks OK!

@divipillai divipillai added this to the 2.9.0 milestone Dec 5, 2024
@divipillai divipillai added backport v2.9-branch auto-create a PR with same commits to v2.9-branch and removed DNM labels Dec 5, 2024
Moved Thingy:91 and Thingy:91 x under application development.

Signed-off-by: divya pillai <[email protected]>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 6, 2024
@divipillai divipillai removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 6, 2024
@divipillai
Copy link
Contributor Author

divipillai commented Dec 6, 2024

@gmarull : The compliance error is because of the image size of existing images. I think we could override this compliance check?

@rlubos rlubos merged commit 5e2c101 into nrfconnect:main Dec 6, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v2.9-branch auto-create a PR with same commits to v2.9-branch CI-disable Disable CI for this PR doc only doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants